[Bugfix] Fix NameError in OmniDiffusion init for Bagel/NextStep after GLM-Image merge#1563
Closed
lishunyang12 wants to merge 1 commit intovllm-project:mainfrom
Closed
Conversation
Contributor
Author
|
Verified the bug and fix by simulating the dispatch logic in Bagel/NextStep branches set |
Collaborator
fix DCO |
5 tasks
… GLM-Image merge Signed-off-by: lishunyang <lishunyang12@163.com>
a4388be to
0f29d8e
Compare
Semmer2
reviewed
Feb 28, 2026
| od_config.model_class_name = pipeline_class | ||
| od_config.tf_model_config = TransformerConfig() | ||
| od_config.update_multimodal_support() | ||
|
|
Contributor
There was a problem hiding this comment.
Hi, Shunyang, I thinke these three lines of code is common, which should not be deleted and added in former if-else code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OmniDiffusion.__init__but introduced a bug: the GLM-Image and single-architecture branches assign to a localpipeline_classvariable, while lines 93-98 unconditionally read it. When Bagel or NextStep models hit their branches (which setod_configdirectly),pipeline_classis never defined, causing aNameError.od_config.model_class_name,tf_model_config, and callsupdate_multimodal_support()directly. No sharedpipeline_classvariable needed.Test plan
OmniDiffusion(model="ByteDance-Seed/BAGEL-7B-MoT")OmniDiffusion(model="THUDM/GLM-Image-1.0")