[BugFix]: fix a lot of bug#1565
Merged
hsliuustc0106 merged 4 commits intovllm-project:mainfrom Feb 28, 2026
Merged
Conversation
Signed-off-by: princepride <wangzhipeng628@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c4c436caa
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: princepride <wangzhipeng628@gmail.com>
Signed-off-by: princepride <wangzhipeng628@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Fix multiple bugs affecting Bagel and GLM-Image model pipelines, including model initialization failures, weight loading errors, and intermittent KV cache transfer issues.
1. Fix Bagel ViT weight loading failures (
pipeline_bagel.py)SiglipNaViTWrappercreatedpatch_embed_weight/patch_embed_biasattributes that aliased canonical parameters inpatch_embedding, causing false positives in the strict weight loading check. Removed the aliases and access the patch embedding parameters directly inforward().vit_config.json) specifies 27 layers with a head, but the actual Bagel checkpoint has 26 layers and no head. Added overrides to align theSiglipVisionModelconfig with the checkpoint.2. Fix GLM-Image transformer weight loading check failure (
pipeline_glm_image.py)GlmImagePipeline.load_weights()stripped thetransformer.prefix before delegating to the transformer, but didn't re-add it to the returned set of loaded weight names. The strict check compared prefixed expected names against unprefixed loaded names, causing all transformer weights to be reported as uninitialized.3. Fix intermittent KV cache transfer failure (
shm_connector.py,chunk_transfer_adapter.py)SharedMemoryConnector.get()returned(None, 0)on failure, which is truthy, causing the caller's polling loop to exit prematurely and treat a not-yet-ready transfer as a successful zero-byte read. Changed all failure return paths toNone(falsy) and added a correspondingNoneguard inchunk_transfer_adapter.pybefore tuple unpacking.4. Fix vllm 0.16.0 import incompatibility (
glm_image_ar.py)from vllm.attention.layer import Attentiondoes not exist in vllm 0.16.0. Updated to the correct pathfrom vllm.model_executor.layers.attention import Attention.Test Plan
python3 examples/offline_inference/bagel/end2end.py --prompts "A cute cat" --modality text2imgpython3 end2end.py --model-path /proj-tango-pvc/users/zhipeng.wang/workspace/models/GLM-Image --prompt "A cat sitting on the table" --output cat.png --config-path /proj-tango-pvc/users/zhipeng.wang/workspace/vllm-omni/vllm_omni/model_executor/stage_configs/glm_image.yamlTest Result