[1/N][Refactor] Clean up dead code in output processor#1579
Open
gcanlin wants to merge 1 commit intovllm-project:mainfrom
Open
[1/N][Refactor] Clean up dead code in output processor#1579gcanlin wants to merge 1 commit intovllm-project:mainfrom
gcanlin wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.
Purpose
Related to #1577. Phase 0 clean the dead code:
register_handler(),output_handlersdict, and custom handler dispatch (zero callers)_reqid_to_mm_type(populated but never read)_process_text_image_output(no config uses "text+image")_extract_from_multimodal_outputs(eco has nomultimodal_outputsattr, always returns None)_process_pooling_output(callstorch.as_tensoron a dict — broken)_process_text_output(no-op)_route_and_normalizeand all_process_*_outputmethods (entire routing layer was a no-op in production)"model_outputs"fallback inserving_speech.py(key remapping ensures it's always"audio")Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)