Skip to content

[1/N][Refactor] Clean up dead code in output processor#1579

Merged
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
gcanlin:output-proc-clean
Mar 6, 2026
Merged

[1/N][Refactor] Clean up dead code in output processor#1579
hsliuustc0106 merged 1 commit intovllm-project:mainfrom
gcanlin:output-proc-clean

Conversation

@gcanlin
Copy link
Collaborator

@gcanlin gcanlin commented Mar 1, 2026

PLEASE FILL IN THE PR DESCRIPTION HERE ENSURING ALL CHECKLIST ITEMS (AT THE BOTTOM) HAVE BEEN CONSIDERED.

Purpose

Related to #1577. Phase 0 clean the dead code:

  • Remove register_handler(), output_handlers dict, and custom handler dispatch (zero callers)
  • Remove _reqid_to_mm_type (populated but never read)
  • Remove _process_text_image_output (no config uses "text+image")
  • Remove _extract_from_multimodal_outputs (eco has no multimodal_outputs attr, always returns None)
  • Remove _process_pooling_output (calls torch.as_tensor on a dict — broken)
  • Remove _process_text_output (no-op)
  • Remove _route_and_normalize and all _process_*_output methods (entire routing layer was a no-op in production)
  • Remove dead "model_outputs" fallback in serving_speech.py (key remapping ensures it's always "audio")

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan. Please provide the test scripts & test commands. Please state the reasons if your codes don't require additional test scripts. For test file guidelines, please check the test style doc
  • The test results. Please paste the results comparison before and after, or the e2e results.
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model. Please run mkdocs serve to sync the documentation editions to ./docs.
  • (Optional) Release notes update. If your change is user-facing, please update the release notes draft.

BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
@gcanlin gcanlin requested a review from hsliuustc0106 as a code owner March 1, 2026 13:50
Copy link
Contributor

@lishunyang12 lishunyang12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean dead code removal. The serving_speech.py fallback key change is safe since the output processor normalizes model_outputs to the modality key upstream.

@gcanlin gcanlin added the ready label to trigger buildkite CI label Mar 4, 2026
Copy link
Collaborator

@hsliuustc0106 hsliuustc0106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hsliuustc0106
Copy link
Collaborator

@tzhouam PTAL

@hsliuustc0106 hsliuustc0106 merged commit 846167b into vllm-project:main Mar 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready label to trigger buildkite CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants