[Bugfix] Enforce --max-generated-image-size on /v1/images/generations#2599
Merged
david6666666 merged 1 commit intovllm-project:mainfrom Apr 9, 2026
Merged
Conversation
The /v1/images/edits endpoint validates the requested image size against --max-generated-image-size, but /v1/images/generations does not. Add the same width*height check to generate_images that edit_images already has. Closes vllm-project#2586 Co-authored-by: Claude <noreply@anthropic.com> Signed-off-by: Nick Cao <ncao@redhat.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
32 tasks
Collaborator
|
LGTM. Thanks for your contribution. |
david6666666
approved these changes
Apr 9, 2026
lvliang-intel
pushed a commit
to lvliang-intel/vllm-omni
that referenced
this pull request
Apr 9, 2026
…vllm-project#2599) Signed-off-by: Nick Cao <ncao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com>
david6666666
added a commit
to david6666666/vllm-omni
that referenced
this pull request
Apr 9, 2026
…vllm-project#2599) Signed-off-by: Nick Cao <ncao@redhat.com> Co-authored-by: Claude <noreply@anthropic.com> (cherry picked from commit 3bd8a52) Signed-off-by: David Chen <530634352@qq.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The /v1/images/edits endpoint validates the requested image size against --max-generated-image-size, but /v1/images/generations does not. Add the same width*height check to generate_images that edit_images already has.
Closes #2586
Test Plan
Test Result
PASS
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model. Please runmkdocs serveto sync the documentation editions to./docs.BEFORE SUBMITTING, PLEASE READ https://github.com/vllm-project/vllm-omni/blob/main/CONTRIBUTING.md (anything written below this line will be removed by GitHub Actions)