Conversation
There was a problem hiding this comment.
Pull request overview
Updates README.md to provide a more complete project overview and clearer guidance for installation, usage, testing, benchmarks, and design rationale.
Changes:
- Expanded README with table of contents and clearer “About”/“Supported Kernels” sections.
- Added structured installation/build instructions plus testing and benchmark usage.
- Refined design notes explaining the rationale for statically linking oneDNN.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Prepare | ||
| - **Python**: 3.9 – 3.12 | ||
| - **PyTorch**: 2.10.0+xpu |
There was a problem hiding this comment.
The README lists PyTorch: 2.10.0+xpu as a requirement, but the build system currently expects torch 2.9.0 for XPU (see CMakeLists.txt TORCH_SUPPORTED_VERSION_XPU). This mismatch is likely to confuse users and may lead to builds running with an unsupported torch version; please align the README requirement with the version(s) actually supported by the build (or update the build checks if 2.10 is now the intended target).
| - **PyTorch**: 2.10.0+xpu | |
| - **PyTorch**: 2.9.0+xpu |
There was a problem hiding this comment.
The CMakLists.txt needs to be updated for TORCH_SUPPORTED_VERSION_XPU to 2.10
jikunshang
left a comment
There was a problem hiding this comment.
pls fix pre-commit issue, also add this for developer https://docs.vllm.ai/en/latest/contributing/?h=lint#linting
Signed-off-by: Roger Feng <roger.feng@intel.com>
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.readme.md update.