Skip to content

fix install build file lack #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix install build file lack #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4c639d8
fix install build file lack
jikunshang Sep 24, 2025
074c72f
use install instead of develop for setup.py in docker build
jikunshang Sep 24, 2025
ae84aed
remove import _xxx_C
jikunshang Sep 24, 2025
83a3378
always remove container even if failed
jikunshang Sep 24, 2025
29dcdec
switch to pip install instead of python setup.py
jikunshang Sep 25, 2025
b0fbd78
ci path
jikunshang Sep 25, 2025
bcf1783
use develop build, avoid python test local first
jikunshang Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ut.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,9 @@ jobs:
--name vllm-xpu-kernel-ci \
xpu-kernel-ci-image \
/bin/bash -c '
cd /workspace/vllm-xpu-kernels
pytest -v -s tests/
pytest -v -s /workspace/vllm-xpu-kernels/tests/
'
- name: Remove container
if: ${{ always() }}
run: |
docker rm -f vllm-xpu-kernel-ci || true
2 changes: 1 addition & 1 deletion Dockerfile.xpu
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ RUN --mount=type=cache,target=/root/.cache/pip \
-r requirements.txt

RUN --mount=type=cache,target=/root/.cache/pip \
python3 setup.py develop
pip install --extra-index-url=https://download.pytorch.org/whl/xpu -e . -v
18 changes: 15 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,19 +26,31 @@ pip install -r requirements.txt
Build development installation to current directory:

```
VLLM_TARGET_DEVICE=xpu python3 setup.py develop
pip install --extra-index-url=https://download.pytorch.org/whl/xpu -e . -v
# or
pip install --no-build-isolation -e . -v
```

or installation to system directory:

```
VLLM_TARGET_DEVICE=xpu python3 setup.py install
pip install --extra-index-url=https://download.pytorch.org/whl/xpu .
# or
pip install --no-build-isolation .
```

or build wheel (generated .whl in dist folder)

```
VLLM_TARGET_DEVICE=xpu python3 setup.py bdist_wheel
pip wheel --extra-index-url=https://download.pytorch.org/whl/xpu .
# or
pip wheel --no-build-isolation .
```

Incremental build

```
python3 -m build --wheel --no-isolation
```

### How to use in vLLM
Expand Down
8 changes: 4 additions & 4 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ requires = [
"packaging>=24.2",
"setuptools>=77.0.3,<80.0.0",
"setuptools-scm>=8.0",
"torch == 2.7.0",
"torch == 2.8.0+xpu",
"wheel",
"regex",
"jinja2",
"build"
]
build-backend = "setuptools.build_meta"

Expand Down Expand Up @@ -42,9 +43,8 @@ Documentation="https://docs.vllm.ai/en/latest/"
[tool.setuptools_scm]
# no extra settings needed, presence enables setuptools-scm

[tool.setuptools.packages.find]
where = ["."]
include = ["vllm_xpu_kernels*"]
[tool.setuptools]
packages = ["vllm_xpu_kernels"]
Copy link

Copilot AI Sep 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The explicit packages configuration may not include subdirectories or subpackages within vllm_xpu_kernels. Consider using find_packages() or explicitly listing all subpackages if they exist, or use packages = {"vllm_xpu_kernels": "vllm_xpu_kernels"} with include-package-data = true to ensure all necessary files are included.

Suggested change
packages = ["vllm_xpu_kernels"]
packages = "find:"
include-package-data = true

Copilot uses AI. Check for mistakes.

[tool.yapfignore]
ignore_patterns = [
Expand Down
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ packaging>=24.2
setuptools-scm>=8
setuptools>=77.0.3,<80.0.0
wheel
build

# torch dependency
--extra-index-url=https://download.pytorch.org/whl/xpu
Expand Down