Skip to content

Conversation

vadiklyutiy
Copy link
Contributor

@vadiklyutiy vadiklyutiy commented Apr 14, 2025

We keep 2 MM caches in Client/Frontend and Server/EngineCore (see detailed description in the top of /vllm/v1/engine/mm_input_cache.py ).

In case on cache hit on Client side we didn't update access time because did only in that not update access time by design. On Server side we make explicit access. In result LRU order was inconsistent and over time, the cache content also became inconsistent.

This PR add dummy access on Client side to keep access times consistent.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Apr 14, 2025
Signed-off-by: Vadim Gimpelson <[email protected]>
@DarkLight1337
Copy link
Member

Thanks, I have already opened a PR #16593 to fix this though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants