-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
[Bugfix] Bump DeepGEMM Version to Fix SMXX Layout Issues #22606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the DEEPGEMM_GIT_REF
in the Dockerfile to a newer commit to fix an smxx
layout assertion error. The change is well-justified by the provided logs showing the error is resolved. The update to the specific commit hash is appropriate given the DeepGEMM repository does not use tags or releases. The change correctly addresses the bug and improves the stability of the vLLM build.
Signed-off-by: frankwang28 <[email protected]>
c508d21
to
5d563a4
Compare
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for testing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the work!
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
There is a newer version of DeepGEMM which fixes some bugs, notably around smxx layout assertions. The current version of DeepGEMM in the Dockerfile does not have these fixes and we should bump the git reference accordingly. For reference, I am encountering the issue when serving DeepSeek-R1-0528 on 8xB200 with DeepGEMM, expert parallelism (DP=8, TP=1) and pplx All2All backend.
Test Plan
Launch vLLM before and after the updated DeepGEMM version.
Test Result
Before:
After:
(Optional) Documentation Update