-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
[BugFix] [Spec Decode] Remove LlamaForCausalLMEagle3 to fix CI #22611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: 22quinn <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Warning Gemini encountered an error creating the review. You can try again by commenting |
The test is still failing, PTAL |
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
@DarkLight1337 sorry this becomes more involved than I expected, so I removed it to unblock CI. |
Should we comment out the model instead of deleting it? (Makes it easier for future maintainers to know what to add back) |
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
Head branch was pushed to by a user without write access
Signed-off-by: 22quinn <[email protected]>
Signed-off-by: 22quinn <[email protected]>
…project#22611) Signed-off-by: 22quinn <[email protected]> Signed-off-by: jingyu <[email protected]>
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.Purpose
"Basic Models Test" has been failing due to some eagle models not named with "eagle-" or "eagle3-" prefix.
This is a short-term fix to make CI green. In the long-term, maybe eagle models should use
model_type
instead of the name to identify itself, similar to medusa models. But that requires updatingconfig.json
in HF repo cc @Liyuhui-12 @LiuXiaoxuanPKUTest Plan
pytest tests/models/test_initialization.py
Test Result
passed
(Optional) Documentation Update