Skip to content

Conversation

Jialin
Copy link
Contributor

@Jialin Jialin commented Aug 13, 2025

Essential Elements of an Effective PR Description Checklist

  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.

Purpose

Also comment out corresponding ids in @pytest.mark.parametrize to ensure params and IDs count matched.

Culprit diff: Only params are commented out in #22611

Test Plan

pytest tests/v1/e2e/test_spec_decode.py

Test Result

test_spec_decode finished successfully

(Optional) Documentation Update

Signed-off-by: Jialin Ouyang <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label Aug 13, 2025
@Jialin
Copy link
Contributor Author

Jialin commented Aug 13, 2025

CC @22quinn

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a failing test, test_spec_decode, by commenting out a test ID to match the number of test parameters in test_eagle_correctness. This resolves the mismatch that was causing CI failures. The change is straightforward and I have no further recommendations.

@22quinn
Copy link
Collaborator

22quinn commented Aug 13, 2025

Thanks for the fix! This was merged in #22847

@Jialin
Copy link
Contributor Author

Jialin commented Aug 13, 2025

Thanks for the fix! This was merged in #22847

Ah! Great! Thanks for sharing.

@Jialin Jialin closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants