-
-
Notifications
You must be signed in to change notification settings - Fork 9.9k
Revert gemma3n fast prefill changes #23897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This PR reverts the gemma3n
fast prefill feature to fix failing tests. The changes within the model files are correct. However, the revert is incomplete, leaving behind dead code, configuration options, and tests related to the removed feature. I've added a critical comment pointing out the need for a complete revert to maintain code health.
Need to ensure Multi-modal processor tests pass before merging this PR. |
@sarckk v1-test-e2e-plus-engine fails and is related to this PR. |
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Matthew Bonanni <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]>
Signed-off-by: Yong Hoon Shin <[email protected]> Signed-off-by: Shiyan Deng <[email protected]>
Purpose
Multi-modal processor tests for
H2OVLChatModel
andKimiVLForConditionalGeneration
are broken on trunk after merging #22628.I was previously unable to reproduce this issue locally as it requires that these test cases come after the Gemma3n test case. The failures are:
H20VLChatModel
TypeError: _LazyConfigMapping.__init__() missing 1 required positional argument: 'mapping'
Kimi (OOM)
This PR reverts gemma3n changes in #22628 (commit c498483) which fixes the tests.
Test Plan
Test Result
Multi-Modal Processor Test should pass in CI
Essential Elements of an Effective PR Description Checklist
supported_models.md
andexamples
for a new model.