Skip to content

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Oct 15, 2025

Purpose

This is a retry of #26663. That PR is showing some really strange behaviour in CI (CPU tests running things they shouldn't). I wanted to make a clean PR to double check there is not something screwed up with that build and that it is indeed reproducible.

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Co-authored-by: Huamin Li <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
@mergify mergify bot added the v1 label Oct 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a test for the Triton attention backend by correctly transposing the KV cache to the format it expects. The change also refactors the logic to separate the cache transformation common to both FlashInfer and Triton from the logic specific to FlashInfer. The changes are correct and improve the test's correctness and structure. I have no further comments.

@tdoublep
Copy link
Member Author

Have triggered the "V1 Test others (CPU)" job here: https://buildkite.com/vllm/fastcheck/builds/44832#0199e7a9-2267-4771-a13a-4e4b853f3159

@tdoublep
Copy link
Member Author

Closing since it shows the same behaviour as the other PR. Will comment more on my findings there.

@tdoublep tdoublep closed this Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant