[docs] Fix cudagraph mode config #29170
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: angelayi <[email protected]>
|
Documentation preview: https://vllm--29170.org.readthedocs.build/en/29170/ |
mergify
bot
added
documentation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request fixes a typo in the documentation for debugging vLLM with torch.compile. Specifically, it corrects the example for disabling CUDAGraphs in the configuration table. The previous example incorrectly showed mode=CompilationMode.NONE, which disables torch.compile entirely, instead of the correct cudagraph_mode=CUDAGraphMode.NONE which only disables CUDAGraphs. The change is accurate and improves the clarity of the documentation for developers. The pull request looks good to merge.
Collaborator
|
@hmellor I'm not sure what happened to the docs build, should we rebase? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes small typo at the table in https://docs.vllm.ai/en/latest/design/debug_vllm_compile/ on the cudagraph configs
cc @zou3519 @ProExpertProg