-
-
Notifications
You must be signed in to change notification settings - Fork 11.5k
[Frontend][Responses API] Multi-turn (with type: "output_text") support for non-harmony requests #29175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Mads Kildegård <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to add support for output_text in multi-turn requests. The change correctly identifies one location where output_text should be handled as a text-like content part. However, a critical part of the implementation is missing in MM_PARSER_MAP. Without this, the content of output_text parts will be lost during processing, leading to corrupted model inputs. I've added a critical review comment with details on how to fix this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Mads Kildegård <[email protected]>
chaunceyjiang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you help test what the result would be when the OpenAI online service handles this kind of request?
|
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run You ask your reviewers to trigger select CI tests on top of Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add If you have any questions, please reach out to us on Slack at https://slack.vllm.ai. 🚀 |
|
Sure, here's an example when using OpenAI through python: prints: |
Purpose
Add support for multi-turn requests that has content with type
output_texton the Responses API for non-harmony messages.Test Plan
Currently this request:
returns:
Test Result
When adding
"output_text"to the supported content part types the request succeeds:Essential Elements of an Effective PR Description Checklist