Skip to content

Conversation

@Inokinoki
Copy link

@Inokinoki Inokinoki commented Nov 21, 2025

Purpose

During my build for AMD HIP, I saw:

-- Found Torch: /home/inoki/Projects/Builds/test-pytorch/.venv/lib/python3.11/site-packages/torch/lib/libtorch.so  
-- The HIP compiler identification is Clang 19.0.0
-- Detecting HIP compiler ABI info
-- Detecting HIP compiler ABI info - done
-- Check for working HIP compiler: /opt/rocm-6.4.0/lib/llvm/bin/clang++ - skipped
-- Detecting HIP compile features
-- Detecting HIP compile features - done
CMake Warning at CMakeLists.txt:140 (message):
  Pytorch version >= 2.9.0 expected for ROCm build, saw 2.9.1 instead.

where the warning seems to be confusing

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added ci/build rocm Related to AMD ROCm labels Nov 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue with a confusing warning message during ROCm builds. The previous logic incorrectly triggered a warning when the PyTorch version was newer than the minimum required version. The change modifies the CMake version check from NOT VERSION_EQUAL to VERSION_LESS, which aligns the logic with the warning message's intent of ensuring a minimum PyTorch version. The fix is accurate and resolves the reported problem.

@Inokinoki Inokinoki force-pushed the improve-hip-version-finding-warning branch from a79d15b to b61f549 Compare November 21, 2025 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/build rocm Related to AMD ROCm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant