Skip to content

Conversation

@yewentao256
Copy link
Member

@yewentao256 yewentao256 commented Nov 21, 2025

Purpose

Pre-commit fails, complaining

❌ Forbidden direct `import triton` detected. ➤ Use `from vllm.triton_utils import triton` instead.

❌ vllm/v1/worker/gpu/block_table.py:6: import triton
❌ vllm/v1/worker/gpu/block_table.py:7: import triton.language as tl
❌ vllm/v1/worker/gpu/input_batch.py:10: import triton
❌ vllm/v1/worker/gpu/input_batch.py:11: import triton.language as tl
❌ vllm/v1/worker/gpu/sampler.py:6: import triton
❌ vllm/v1/worker/gpu/sampler.py:7: import triton.language as tl

This PR fixes the issue

Signed-off-by: yewentao256 <[email protected]>
@mergify mergify bot added the v1 label Nov 21, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request resolves a CI failure by refactoring how the triton library is imported. The changes replace direct imports with a centralized import from vllm.triton_utils in block_table.py, input_batch.py, and sampler.py. This is a good practice that correctly fixes the reported issue. The changes are sound and I have no further suggestions.

@yewentao256 yewentao256 added ready ONLY add when PR is ready to merge/full CI is needed force-merge labels Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-merge ready ONLY add when PR is ready to merge/full CI is needed v1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants