[CI/Build] Disable test_gptoss_tp.py in 'LoRA TP Test' group for ROCm platform #29204
+4
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… platform Signed-off-by: qli88 <[email protected]>
mergify
bot
added
ci/build
gpt-oss
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request disables the test_gptoss_tp.py test for the ROCm platform in the CI configuration. The reason provided is that the MXFP4 backend does not yet support LoRA on non-CUDA platforms, which is accurate based on the current implementation. The change is a valid workaround to prevent CI failures until the feature is supported. The modification is correct and well-commented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to disable test_gptoss_tp.py in test group "LoRA TP Test" because MXFP4 backend on non-cuda platform does not support LoRA yet.