Skip to content

Conversation

@kkr16
Copy link

@kkr16 kkr16 commented Dec 20, 2025

Purpose

Allow specifying a custom TAG environment variable for auto_tune.sh.
This is useful when collecting logs from distributed jobs (e.g., on Kubernetes) where a unique identifier or timestamp needs to be coordinated externally or synced with other components, rather than relying on the script's internal execution time.
It also allows for higher resolution in the TAG, as the current TAG only offers minute precision, which can cause collisions if multiple jobs are started within the same minute.
This does NOT alter the default behaviour of auto_tune.sh.

Test Plan

  1. Custom TAG: Run auto_tune.sh with a static custom tag:
TAG=custom-tag ./benchmarks/auto_tune/auto_tune.sh
  1. Custom TAG + Timestamp: Run auto_tune.sh with a custom tag including a timestamp:
TAG=custom-tag-$(date +"%Y_%m_%d_%H_%M") ./benchmarks/auto_tune/auto_tune.sh
  1. Default behaviour: Run auto_tune.sh without setting TAG:
./benchmarks/auto_tune/auto_tune.sh

Test Result

  1. Verified that the output directory uses custom-tag.
  2. Verified that the output directory uses the format custom-tag-YYYY_MM_DD_HH_MM.
  3. Verified that the output directory falls back to the default timestamp format YYYY_MM_DD_HH_MM.

Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • [] (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

@github-actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

@mergify mergify bot added the performance Performance-related issues label Dec 20, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly implements the ability to override the TAG environment variable in auto_tune.sh. However, this introduces a critical security vulnerability. The TAG variable is used to construct a directory path that is later deleted with rm -rf. Without sanitization, a malicious TAG could lead to path traversal and the deletion of arbitrary files and directories. I have added a review comment with a suggestion to sanitize the TAG variable to prevent this.

kkr16 and others added 2 commits December 22, 2025 21:15
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Karim Roukoz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

performance Performance-related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant