Add explicit validation error for tool calls.#34438
Open
juliendenize wants to merge 2 commits intovllm-project:mainfrom
Open
Add explicit validation error for tool calls.#34438juliendenize wants to merge 2 commits intovllm-project:mainfrom
juliendenize wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: juliendenize <[email protected]>
This was referenced Feb 12, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces an explicit validation error for tool_calls to improve error handling when invalid data is provided. The change correctly catches pydantic.ValidationError and raises a more user-friendly ValueError. I've suggested a refactoring to make the implementation more concise and Pythonic by using list() to consume the iterator, which simplifies the code while maintaining the same logic.
Signed-off-by: juliendenize <[email protected]>
patrickvonplaten
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Add explicit validation error for tool calls.
Fix #34225
Test Plan
Checked with these messages in the request:
Test Result
Raised correctly:
Essential Elements of an Effective PR Description Checklist