Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
The pull request correctly addresses the flakiness in the CI by skipping the test_mcp_code_interpreter_streaming test in tests/entrypoints/openai/responses/test_harmony.py. The skip reason provided is clear and points to the need for further investigation into the code interpreter MCP implementation. This change is an appropriate short-term measure to ensure CI reliability while the underlying issues are being addressed.
aarnphm
approved these changes
Feb 20, 2026
Collaborator
|
@robertgshaw2-redhat @LucasWilkinson Can we merge #33949? |
Collaborator
|
#33949 just got merged :) So I suggest that we give it a chance and if it does not solve our problems, revisit skipping these tests. |
simon-mo
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose