[ROCm] Check that AITER MHA is not selected with sinks#34998
Open
gshtras wants to merge 2 commits intovllm-project:mainfrom
Open
[ROCm] Check that AITER MHA is not selected with sinks#34998gshtras wants to merge 2 commits intovllm-project:mainfrom
gshtras wants to merge 2 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
Signed-off-by: Gregory Shtrasberg <Gregory.Shtrasberg@amd.com>
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly adds checks to prevent the selection of the AITER MHA attention backend when sinks are enabled, as this configuration is unsupported. The changes cover both explicit backend selection and automatic selection logic. My review includes one comment pointing out a significant code duplication where a block of logic is redundant and unreachable. I've suggested its removal to improve code clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AITER MHA does not support sinks. Gating its selector
This should unbreak
VLLM_ROCM_USE_AITER=1 vllm serve openai/gpt-oss-120b