Fixing matcher to enable the 2-node-tests-4-gpus-in-total on MI355#35002
Open
Alexei-V-Ivanov-AMD wants to merge 3 commits intovllm-project:mainfrom
Open
Fixing matcher to enable the 2-node-tests-4-gpus-in-total on MI355#35002Alexei-V-Ivanov-AMD wants to merge 3 commits intovllm-project:mainfrom
Alexei-V-Ivanov-AMD wants to merge 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
|
Related Documentation Checked 0 published document(s) in 1 knowledge base(s). No updates required. How did I do? Any feedback? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix a matcher to enable a specific test on MI355 hardware. However, the change to the shell script contains a bug in the matching logic. I've provided a critical review comment with a suggested fix to correctly use a regular expression for matching different hardware prefixes in the test group name, ensuring the test runs as intended.
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing matcher to enable the 2-node-tests-4-gpus-in-total on MI355