Skip to content

Comments

[Deprecation] Remove old locations of get_tokenizer and resolve_hf_chat_template#35024

Draft
DarkLight1337 wants to merge 1 commit intovllm-project:mainfrom
DarkLight1337:rm-tokenizer
Draft

[Deprecation] Remove old locations of get_tokenizer and resolve_hf_chat_template#35024
DarkLight1337 wants to merge 1 commit intovllm-project:mainfrom
DarkLight1337:rm-tokenizer

Conversation

@DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Feb 21, 2026

Purpose

Test Plan

Test Result


Essential Elements of an Effective PR Description Checklist
  • The purpose of the PR, such as "Fix some issue (link existing issues this PR will resolve)".
  • The test plan, such as providing test command.
  • The test results, such as pasting the results comparison before and after, or e2e results
  • (Optional) The necessary documentation update, such as updating supported_models.md and examples for a new model.
  • (Optional) Release notes update. If your change is user facing, please update the release notes draft in the Google Doc.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 21, 2026
@dosubot
Copy link

dosubot bot commented Feb 21, 2026

Related Documentation

Checked 0 published document(s) in 1 knowledge base(s). No updates required.

How did I do? Any feedback?  Join Discord

@DarkLight1337 DarkLight1337 changed the title [Deprecation] Remove get_tokenizer and resolve_hf_chat_template [Deprecation] Remove old locations of get_tokenizer and resolve_hf_chat_template Feb 21, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes deprecated code related to get_tokenizer and resolve_hf_chat_template. The changes are straightforward and correct, consisting of the removal of the vllm/transformers_utils/tokenizer.py file and the __getattr__ function in vllm/entrypoints/chat_utils.py. This cleanup is well-justified by the update to the lm-eval dependency as mentioned in the description. The changes improve code maintainability by removing obsolete code paths. I approve these changes.

@mergify mergify bot added the frontend label Feb 21, 2026
@DarkLight1337
Copy link
Member Author

Ok turns out lm-eval hasn't been updated with the new import yet. I have opened a PR on their end: EleutherAI/lm-evaluation-harness#3595

@DarkLight1337 DarkLight1337 marked this pull request as draft February 21, 2026 15:20
auto-merge was automatically disabled February 21, 2026 15:20

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend ready ONLY add when PR is ready to merge/full CI is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants