[Deprecation] Remove old locations of get_tokenizer and resolve_hf_chat_template#35024
Draft
DarkLight1337 wants to merge 1 commit intovllm-project:mainfrom
Draft
[Deprecation] Remove old locations of get_tokenizer and resolve_hf_chat_template#35024DarkLight1337 wants to merge 1 commit intovllm-project:mainfrom
get_tokenizer and resolve_hf_chat_template#35024DarkLight1337 wants to merge 1 commit intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
get_tokenizer and resolve_hf_chat_templateget_tokenizer and resolve_hf_chat_template
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes deprecated code related to get_tokenizer and resolve_hf_chat_template. The changes are straightforward and correct, consisting of the removal of the vllm/transformers_utils/tokenizer.py file and the __getattr__ function in vllm/entrypoints/chat_utils.py. This cleanup is well-justified by the update to the lm-eval dependency as mentioned in the description. The changes improve code maintainability by removing obsolete code paths. I approve these changes.
Isotr0py
approved these changes
Feb 21, 2026
Member
Author
|
Ok turns out |
auto-merge was automatically disabled
February 21, 2026 15:20
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
lm-evalhas been updated in Bumplm-evalversion for Transformers v5 compatibility #33994.Test Plan
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.