[Refactor] Simplify dummy data generation#35025
Open
DarkLight1337 wants to merge 8 commits intovllm-project:mainfrom
Open
[Refactor] Simplify dummy data generation#35025DarkLight1337 wants to merge 8 commits intovllm-project:mainfrom
DarkLight1337 wants to merge 8 commits intovllm-project:mainfrom
Conversation
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
|
Documentation preview: https://vllm--35025.org.readthedocs.build/en/35025/ |
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the dummy data generation for multimodal models by centralizing the merging of keyword arguments from the multimodal configuration. This simplifies the get_dummy_mm_data and get_hf_processor methods across numerous model implementations. While the refactor is comprehensive, there are a few inconsistencies in the updated method signatures and missing keyword argument support in some custom processor adapters that could lead to runtime errors.
Isotr0py
approved these changes
Feb 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
mm_processor_kwargsforDummyInputsBuilder#34330)mm_options, so there is no need for implementations to handle the case where it isNoneTest Plan
Using the same test as #34330
Test Result
Essential Elements of an Effective PR Description Checklist
supported_models.mdandexamplesfor a new model.