Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

Increase drain timeout to 5 minutes#1050

Open
rafis wants to merge 1 commit intovmware-archive:masterfrom
rafis:master
Open

Increase drain timeout to 5 minutes#1050
rafis wants to merge 1 commit intovmware-archive:masterfrom
rafis:master

Conversation

@rafis
Copy link

@rafis rafis commented May 31, 2021

To help us process your pull request efficiently, please include:

  • (Required) Short description of changes in the PR topic line

When upgrading 100+ clusters the most often encountered error was drain timeout error:

There are pending pods in node "node-i8ou" when an error occurred: drain did not complete within 1m0s\npod/coredns-85cc5bdd54-pk5cb\nerror: unable to drain node "node-i8ou", aborting command...\n\nThere are pending nodes to be drained:\n node-j9rv\nerror: drain did not complete within 1m0s\n

  • (Required) Detailed description of changes include tests and
    documentation. If the pull request contains multiple commits with
    detailed messages, refer to those instead

  • (Optional) Names of reviewers using @ sign + name


This change is Reviewable

@vmwclabot
Copy link

@rafis, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

Signed-off-by: Rafis Ganeev <rnganeye@mts.ru>
Copy link
Contributor

@rocknes rocknes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rafis)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants