Skip to content
This repository was archived by the owner on Jul 3, 2023. It is now read-only.

Conversation

@ryzhyk
Copy link
Collaborator

@ryzhyk ryzhyk commented Oct 14, 2022

Simplified trait bounds in distinct.rs and window.rs (missed them during recent refactoring).

@gz, with this you shouldn't need encode/decode bounds in these files in #124.

Simplified trait bounds in `distinct.rs` and `window.rs` (missed them
during recent refactoring).
@ryzhyk ryzhyk requested a review from gz October 14, 2022 15:57
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #213 (d72bbd9) into main (2cb2a8b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #213   +/-   ##
=======================================
  Coverage   84.06%   84.07%           
=======================================
  Files         127      127           
  Lines       23460    23452    -8     
=======================================
- Hits        19722    19717    -5     
+ Misses       3738     3735    -3     
Impacted Files Coverage Δ
src/operator/time_series/window.rs 98.63% <ø> (ø)
src/operator/distinct.rs 94.55% <100.00%> (-0.09%) ⬇️
src/nexmark/generator/bids.rs 98.40% <0.00%> (-0.80%) ⬇️
src/time/nested_ts32.rs 72.60% <0.00%> (ø)
src/trace/spine_fueled.rs 83.61% <0.00%> (+0.37%) ⬆️
src/circuit/dbsp_handle.rs 92.57% <0.00%> (+0.99%) ⬆️

Copy link
Contributor

@gz gz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm will update my branch after this is merged

@ryzhyk ryzhyk merged commit 59336b4 into vmware-archive:main Oct 14, 2022
@ryzhyk ryzhyk deleted the distinct_trait_bounds branch October 14, 2022 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants