This repository was archived by the owner on Mar 15, 2022. It is now read-only.
Open
Conversation
Signed-off-by: Mateus Caruccio <mateus.caruccio@getupcloud.com>
Contributor
|
@caruccio Thanks for submitting this! @timothysc do you have a few minutes to take a look? On first glance, I don't think Gauge is the appropriate metric. I think a better metric would of type Counter, that we increment for every event. This will allow Prometheus to calculate the total events ever as well as the rate of new events for any given time period. |
Contributor
|
@caruccio Could you sign your commits? If you can do that (and ideally rebase onto master) I can merge. I can always merge master into your branch via the UI but would prefer the commits just be your own unless you find it easier to have me do that part. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey. Does it makes any sense for you?