Skip to content
This repository was archived by the owner on Jan 20, 2026. It is now read-only.

chore: Add test for renewLease#38

Open
vmwjc wants to merge 2 commits intomainfrom
test-lease-renewal
Open

chore: Add test for renewLease#38
vmwjc wants to merge 2 commits intomainfrom
test-lease-renewal

Conversation

@vmwjc
Copy link
Contributor

@vmwjc vmwjc commented Apr 8, 2023

No description provided.

@vmwjc
chore: Add test for renewLease
ec7c0b6 
Signed-off-by: John Calixto <jcalixto@vmware.com>
@vmwclabot
Copy link

vmwclabot commented Apr 8, 2023

@vmwjc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwjc vmwjc force-pushed the test-lease-renewal branch from c434f27 to d614bc6 Compare April 8, 2023 18:28
@vmwclabot
Copy link

vmwclabot commented Apr 8, 2023

@vmwjc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwjc vmwjc force-pushed the test-lease-renewal branch from d614bc6 to 01cd6ad Compare April 8, 2023 18:30
@vmwclabot
Copy link

vmwclabot commented Apr 8, 2023

@vmwjc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwjc vmwjc force-pushed the test-lease-renewal branch from 01cd6ad to c7d725d Compare April 8, 2023 19:01
@vmwclabot
Copy link

vmwclabot commented Apr 8, 2023

@vmwjc, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@vmwjc vmwjc force-pushed the test-lease-renewal branch from c7d725d to 593e85a Compare April 8, 2023 19:02
@vmwjc
fix: Move getRecords stop condition checking to top of loop
4866517 
Added tests to validate coordination of the lease renewal with the
record getting and processing routines. This brought to light the value
of checking the loop's "stop conditions" early in the loop instead of at
the end.

Signed-off-by: John Calixto <jcalixto@vmware.com>
@vmwjc vmwjc force-pushed the test-lease-renewal branch from 593e85a to 4866517 Compare April 8, 2023 19:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vmwjc @vmwclabot