Skip to content

Conversation

@SheryarButt
Copy link

Special notes for your reviewer:

This PR corresponds to issue #698, and removes the use of bitnami kubectl image in favor of registry.k8s.io

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped, please refer to the chart version instruction
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@github-actions github-actions bot requested review from jenting and reasonerjt July 29, 2025 07:51
@SheryarButt SheryarButt force-pushed the chore/migrate-from-bitnami branch 3 times, most recently from ede7e07 to 1b84cbd Compare July 29, 2025 09:37
… change kubectl image repository from bitnami to registry.k8s.io

Signed-off-by: sheryarbutt <m.sheryarbutt@gmail.com>
@SheryarButt SheryarButt force-pushed the chore/migrate-from-bitnami branch from 1b84cbd to 937e8b3 Compare July 29, 2025 09:38
@judge-red
Copy link

I'm not a codeowner for this repo so this isn't a formal review. But this is a breaking change and I think this Helm chart uses semver, so please don't just bump the patch version.

People who use their own registry but don't ovverwrite the tag will have a bad time otherwise.

Signed-off-by: sheryarbutt <m.sheryarbutt@gmail.com>
@SheryarButt SheryarButt marked this pull request as draft July 29, 2025 13:22
@mjnagel
Copy link

mjnagel commented Jul 30, 2025

Due to the k8s registry kubectl image not having a shell (and the same is true with most other kubectl images) this work might also require fixing #571 unless there's a viable alternative kubectl image with which, sh, and kubectl.

@SheryarButt
Copy link
Author

@mjnagel that was the reason to put this PR to draft, sadly other alternatives are alpine based and doesn't have a sh binary that can be copied over. This would require some rework for the upgrade-crds job. Otherwise, the only viable option is to stick with bitnamilegacy images for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants