🌱 Include VM MoID in its logger #1408
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the VM's Status.UniqueID if set. Generally this will always be set on an existing VM. While here, move setting the govmomi types.ID into a helper function, and do a TODO of including our generated reconcile IDs in the logger if the orginal context do not have a controller-runtime ReconcileID.
bryanv
force-pushed
the
bryanv/include-vm-moid-in-logs
branch
from
7af55b6 to
0d4a2f6
Compare
Minimum allowed line rate is |
dilyar85
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Use the VM's Status.UniqueID if set. Generally this will always be set on an existing VM.
While here, move setting the govmomi types.ID into a helper function, and do a TODO of including our generated reconcile IDs in the logger if the original context do not have a controller-runtime ReconcileID.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: