🐛 Infer storage profile from the underlying disk #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when VM Operator finds an unmanaged disk, before registering it as PVCs, it ensures that the disk has a valid storage profile assigned -- and tries to find a StroageClass that maps to the profile associated with the disk. We have a bug where the current code simply applies the VM storage class (vm.Spec.StroageClass) to the disk regardless of what the profile associated with the underlying disk. This assumption was correct for greenfield VMs because we don't support a way to specify a different storage profile for the classic disk. However, for imported VMs, this is not the case. This change fixes this bug by setting the storage profile for the disk by looking up the underlying disk. Consequently, the PVC also now has correct StorageClass.
aruneshpa
force-pushed
the
bug/fix-storage-class-for-classic-disk-imported-vm
branch
from
584717d to
322db85
Compare
github-actions
bot
added
size/L
aruneshpa
changed the title
Minimum allowed line rate is |
srajashekar-vmw
approved these changes
Jan 11, 2026
bryanv
approved these changes
Jan 12, 2026
aruneshpa
deleted the
bug/fix-storage-class-for-classic-disk-imported-vm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Currently, when VM Operator finds an unmanaged disk, before registering it as PVCs, it ensures that the disk has a valid storage profile assigned -- and tries to find a StroageClass that maps to the profile associated with the disk. We have a bug where the current code simply applies the VM storage class (
vm.Spec.StroageClass) to the disk regardless of what the profile associated with the underlying disk. This assumption was correct for greenfield VMs because we don't support a way to specify a different storage profile for the classic disk. However, for imported VMs, this is not the case.This change fixes this bug by setting the storage profile for the disk by looking up the underlying disk. Consequently, the PVC also now has correct StorageClass.
Testing Done: This has been validated in an env.
Please add a release note if necessary: