🌱 Add Disabled field to VM bootstrap #1429
Open
+228
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanv
force-pushed
the
bryanv/bootstrap-add-disabled
branch
from
038f604 to
813c7d4
Compare
bryanv
force-pushed
the
bryanv/bootstrap-add-disabled
branch
from
813c7d4 to
a8fedcd
Compare
Add Disabled field to the VirtualMachineBootstrapSpec to allow skipping bootstrap customization. When true, the VM will not be bootstrapped even if a provider (CloudInit, LinuxPrep, Sysprep, VAppConfig) is specified. This is useful for either disabling the implicit LinuxPrep customization we do on Linux images for historical reasons, or deferring bootstrap when the guest is already configured.
bryanv
force-pushed
the
bryanv/bootstrap-add-disabled
branch
from
a8fedcd to
d685cf2
Compare
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
Add a new Disabled field to the VirtualMachineBootstrapSpec to allow skipping bootstrap customization. When set to true, the VM will not be bootstrapped even if a provider (CloudInit, LinuxPrep, Sysprep, VAppConfig) is specified.
This is useful for deferring bootstrap or when the guest is already configured.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer: