🌱 Add annotation to skip registering unmanaged volumes #1431
+34
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When present, this annotation will cause the reconcile to exit early and update the condition to indicate that the annotation has been seen. This is useful for an external operation that needs to either prevent registration, or perform an unregister once disks are registered.
bryanv
force-pushed
the
bryanv/mobility-rollback-not-crv
branch
from
f1e75eb to
a5ec26c
Compare
github-actions
bot
added
size/M
bryanv
changed the title
Minimum allowed line rate is |
|
|
||
| // NoUnmanagedVolumesRegisterAnnotationKey is the annotation to not create any CNSRegisterVolumes | ||
| // by skipping the unmanaged volume register reconcile. | ||
| NoUnmanagedVolumesRegisterAnnotationKey = "vmoperator.vmware.com/no-unmanaged-volumes-register" |
Contributor
There was a problem hiding this comment.
personally not a fan of the no prefix. what do you think of one of those?
disallow-register-unmanaged-volumesdisallow-unmanaged-volumes-registerprevent-unmanaged-volumes-registerprevent-register-unmanaged-volumes
| logger := pkglog.FromContextOrDefault(ctx) | ||
|
|
||
| if _, ok := vm.Annotations[pkgconst.NoUnmanagedVolumesRegisterAnnotationKey]; ok { | ||
| logger.Info("Skipping register unmanaged volumes because of annotation") |
Contributor
There was a problem hiding this comment.
should we log the annotation here?
| cond := pkgcond.Get(vm, unmanagedvolsreg.Condition) | ||
| Expect(cond).ToNot(BeNil()) | ||
| Expect(cond.Status).To(Equal(metav1.ConditionFalse)) | ||
| Expect(cond.Reason).To(Equal("NoUnmanagedVolumesRegisterAnnotation")) |
Contributor
There was a problem hiding this comment.
shouldn't we have a assertion that we didn't register any volumes
faisalabujabal
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When present, this annotation will cause the reconcile to exit early and update the condition to indicate that the annotation has been seen. This is useful for an external operation that needs to either prevent registration, or perform an unregister once disks are registered.
Which issue(s) is/are addressed by this PR? (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Are there any special notes for your reviewer:
Please add a release note if necessary: