[x-port] [9.1.0] 🐛 Do not reference VM class to get memory required for snapshot #1421 #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re-tanzu#1421) In order to figure out the storage required from the StorageClass to take the snapshot, we look at the VM class to get the memory required for the snapshot in case of a memory-full snapshot. Imported VMs are classless VMs, so that leads to snapshots being rejected for such VMs. This change updates this workflow to reference the VM's status.hardware to get the memory required for this VM's snapshot.
Minimum allowed line rate is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
This is a crossport of commit e09d299 from main to 9.1 branch.
In order to figure out the storage required from the StorageClass to take the snapshot, we look at the VM class to get the memory required for the snapshot in case of a memory-full snapshot. Imported VMs are classless VMs, so that leads to snapshots being rejected for such VMs.
This change updates this workflow to reference the VM's status.hardware to get the memory required for this VM's snapshot.
Please add a release note if necessary: