🐛 Bump up govmomi to pull the vAppConfig fix#1481
Open
hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
Open
🐛 Bump up govmomi to pull the vAppConfig fix#1481hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
hpannem wants to merge 1 commit intovmware-tanzu:mainfrom
Conversation
abaruni
approved these changes
Feb 24, 2026
hpannem
force-pushed
the
topic/hp024696/bugfix-3657670-1
branch
from
6288406 to
2311d23
Compare
github-actions
bot
added
size/L
hpannem
force-pushed
the
topic/hp024696/bugfix-3657670-1
branch
2 times, most recently
from
8da19e4 to
4d242dd
Compare
github-actions
bot
added
size/M
Added a test to test vapp config props Fixed tests due to govmomi changes.
hpannem
force-pushed
the
topic/hp024696/bugfix-3657670-1
branch
from
4d242dd to
7329c71
Compare
Minimum allowed line rate is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do, and why is it needed?
When creating a VM with vApp properties using fast deploy, it fails saying "Invalid value '' specified for property"
This is fixed in vmware/govmomi#3964
This PR pulls the change to vm operator to fix it.
Since govmomi is bumped up, few tests failed. Fixed them.
The test's PBM mock hardcoded "vm-108:203" — a vcsim-internal device key that changed across versions.
To fix this, instead of hardcoding the key in the mock response, the mock now echoes back the exact keys from the incoming PbmQueryAssociatedProfiles request.
Tested with the new vm operator with vApp properties. Now, the creation is successful.