Remove usage of OpenSSL.crypto.sign#1113
Open
salv-orlando wants to merge 1 commit intovmware:masterfrom
Open
Conversation
This method has been removed in PyOpenSSL 24.3.0. This change replaces it with equivalent functions from python's cryptography library. In this way, the pyvim module can be used with recent versions of PyOpenSSL. This needed in particular due to CVE-2026-27459, which requires upgrading PyOpenSSL to 26.0.0. Changes in this commit: - Update the signing logic inside pyVim/sso.py's _sign helper to leverage Python's cryptography package primitives, replacing the legacy OpenSSL.crypto.sign wrapper. - Remove the constraint on pyOpenSSL in pyproject.toml. The whole repository is not using any other deprecated or removed feature in puOpenSSL. Resolves: vmware#1112 Signed-off-by: Salvatore Orlando <salvatore.orlando@broadcom.com>
salv-orlando
force-pushed
the
issue_1112
branch
from
2a66c9c to
7bf7bee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method has been removed in PyOpenSSL 24.3.0.
This change replaces it with equivalent functions from python's cryptography library.
In this way, the pyvim module can be used with recent versions of PyOpenSSL. This needed in particular due to CVE-2026-27459, which requires upgrading PyOpenSSL to 26.0.0.
Changes in this commit:
Resolves: #1112