feat: add support for alarms

[emriver]

Summary

This new feature allows to manage alarms with Terraform.
This will allow to easily duplicate alarm configurations across datacenters, clusters, or even virtual machines.

Type

• fix: Bug Fix
• feat: Feature or Enhancement
• docs: Documentation
• refactor: Refactoring
• chore: Build, Dependencies, Workflows, etc.
• other: Other (Please describe.)

Breaking Changes?

• Yes, there are breaking changes.
• No, there are no breaking changes.

Tests

• Tests have been added or updated.
• Tests have been completed.

Output:

$ TF_ACC=1 go test -timeout 5m -run TestAccResourceVsphereAlarm* github.com/vmware/terraform-provider-vsphere/vsphere -count=1
ok      github.com/vmware/terraform-provider-vsphere/vsphere    218.109s

$ TF_VAR_VSPHERE_DATACENTER=xxx TF_ACC=1 go test -timeout 5m -run TestAccDataSourceVSphereAlarm_* g
ithub.com/vmware/terraform-provider-vsphere/vsphere -count=1
ok      github.com/vmware/terraform-provider-vsphere/vsphere    37.547s

Documentation

• Documentation has been added or updated.

Issue References

Resolves #1312

Release Note

- `r/vsphere_alarm` - Added a new resource for alarms.

Additional Information

Alarms can have a lot of possible parameters and options, I didn't find a way to hide all the complexity (like using a metric_counter_id instead of a user friendly name).
Some of the tests only work with vSphere >= 8.

[tenthirtyam]

Hi @emriver, 👋🏻 Thanks for the contribution - we'll check this one out soon! IN the meantime, would you be open to including the data source as well? This would likely follow a similar structure of the Read structure from the resource.

Ryan Johnson, VMware by Broadcom

[emriver]

Hi @emriver, 👋🏻 Thanks for the contribution - we'll check this one out soon! IN the meantime, would you be open to including the data source as well? This would likely follow a similar structure of the Read structure from the resource.

Ryan Johnson, VMware by Broadcom

Hi, I will try to do it asap. I didn't do it at first because I had doubts about its utility.

[spacegospod]

Looks good, thank you for adding comprehensive tests!

[tenthirtyam]

Just some minor changes requested to the test examples.

[tenthirtyam]

@emriver Can you mark comments as resolved once the update(s) is commited?

[emriver]

@emriver Can you mark comments as resolved once the update(s) is commited?

This should be good now.

[tenthirtyam]

Two more mino nits, but once cleared this should be ready to merge.

[tenthirtyam]

LGTM! 🚀

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.