Add support for project VPCs in network data source#2606
Merged
tenthirtyam merged 1 commit intovmware:mainfrom Sep 16, 2025
Merged
Add support for project VPCs in network data source#2606tenthirtyam merged 1 commit intovmware:mainfrom
tenthirtyam merged 1 commit intovmware:mainfrom
Conversation
github-actions
bot
added
documentation
tenthirtyam
approved these changes
Sep 16, 2025
Contributor
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
Just a minor comment on naming but otherwise LGTM!
ksamoray
force-pushed
the
network-project-vpc
branch
from
a6af00e to
65c7720
Compare
Contributor
Author
|
Post review changes test results: |
Network datasource has a capability to find a network which belongs to NSX default project. But VPC subnets can be nested under different project, and as network names are not unique, it is required to use the project id as part of the network identification. Signed-off-by: Kobi Samoray <kobi.samoray@broadcom.com>
ksamoray
force-pushed
the
network-project-vpc
branch
from
65c7720 to
7d10aa0
Compare
Contributor
|
I'll upstate he commit to conventional commits style and merge:
|
Contributor
|
Merged! 915a700 |
|
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Network datasource has a capability to find a network which belongs to NSX default project.
But VPC subnets can be nested under different project, and as network names are not unique, it is required to use the project id as part of the network identification.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Output:
Documentation
Issue References
Release Note
Add support for project VPCs in network data source
Additional Information