Add ID-based lookup support for vsphere_tag and vsphere_tag_category data sources#2686
Open
akli-ime wants to merge 9 commits intovmware:mainfrom
Open
Add ID-based lookup support for vsphere_tag and vsphere_tag_category data sources#2686akli-ime wants to merge 9 commits intovmware:mainfrom
akli-ime wants to merge 9 commits intovmware:mainfrom
Conversation
github-actions
bot
added
documentation
tenthirtyam
requested changes
Feb 25, 2026
Contributor
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
Please use conventional commits as described in the contributing guidelines for the commits and pull request title.
You can review other commits and closed pull requests to align with the flow we use in the project.
Thanks!
tenthirtyam
requested changes
Feb 25, 2026
Contributor
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
Comments provided for request changes. In addition, the tests should be updated.
Contributor
This does not follow the proper GitHub syntax to link a pull request to an issue. Please refer to Linking a pull request to an issue using a keyword in the GitHub documenation. For example, use one of these options: |
tenthirtyam
requested changes
Feb 26, 2026
Contributor
tenthirtyam
left a comment
tenthirtyam
left a comment
There was a problem hiding this comment.
The tests should be updated.
4 tasks
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
Co-authored-by: Ryan Johnson <ryan@tenthirtyam.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request implements the feature request described in issue #2683 by adding support for resolving vSphere tags and tag categories directly by theirunique ID in the
vsphere_tagandvsphere_tag_categorydata sources.This enhancement improves usability by allowing direct lookup using object IDs, removing the need to know the tag name and category in advance. Documentation has also been updated to reflect the new lookup method and provide examples.
Type
fix: Bug Fixfeat: Feature or Enhancementdocs: Documentationrefactor: Refactoringchore: Build, Dependencies, Workflows, etc.other: Other (Please describe.)Breaking Changes?
Tests
Documentation
Issue References
Resolves #2683
Additional Information
This change is fully backward compatible. Existing configurations using name-based lookups continue to work unchanged.