Skip to content

refactor(rainbowkit-wallets): multiple providers with link#224

Merged
elboletaire merged 5 commits intomainfrom
f/oauth-changes
Jan 29, 2026
Merged

refactor(rainbowkit-wallets): multiple providers with link#224
elboletaire merged 5 commits intomainfrom
f/oauth-changes

Conversation

@elboletaire
Copy link
Member

@elboletaire elboletaire commented Nov 7, 2025

depends on vocdoni/saas-backend#315

This pull request introduces support for linking SaaS OAuth accounts without persisting authentication tokens or wallet data, and adds comprehensive tests for the new and existing OAuth flows. It refactors the wallet creation process to allow control over persistence and updates the OAuth connector to support both login and account linking modes. The most important changes are grouped below:

SaaS OAuth Linking Functionality

  • Added a new linkSaasOAuth utility that allows linking a SaaS OAuth account without persisting authentication tokens or wallet data, and ensures the proper API endpoint and headers are used. (linkSaasOAuth.ts, index.ts) [1] [2]
  • Added tests for the new linking functionality to ensure correct behavior and no persistence of sensitive data. (linkSaasOAuth.test.ts)

OAuth Connector Enhancements

  • Updated saasOauthConnector to support both 'login' and 'link' modes, with dynamic endpoint selection and conditional token persistence. Added options for mode and token retrieval. (saasOauthConnector.ts) [1] [2] [3]
  • Added comprehensive tests for the connector to verify correct token storage on login and no storage on linking, as well as correct API usage. (saasOauthConnector.test.ts)

Wallet Persistence Control

  • Modified localStorageWallet.createWalletFromData and dependent flows to accept a persist option, allowing wallet creation without saving to local storage (used in linking scenarios). (localStorageWallet.ts, saasOauthWallet.tsx, localStorageWallet.test.ts) [1] [2] [3] [4]

@elboletaire elboletaire force-pushed the f/oauth-changes branch 2 times, most recently from 13a6ff3 to 5b4fdd4 Compare January 16, 2026 12:56
@elboletaire elboletaire changed the title chore(rainbowkit-wallets): add oauth provider info to request refactor(rainbowkit-wallets): add oauth provider info to request Jan 16, 2026
@elboletaire elboletaire changed the title refactor(rainbowkit-wallets): add oauth provider info to request refactor(rainbowkit-wallets): multiple providers with link Jan 16, 2026
@elboletaire elboletaire marked this pull request as ready for review January 16, 2026 12:59
@elboletaire elboletaire force-pushed the f/oauth-changes branch 2 times, most recently from 8021631 to 3a8a7aa Compare January 16, 2026 15:50
@elboletaire elboletaire merged commit 4887c1f into main Jan 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant