Demo race condition

.github/workflows/copilot-setup-steps.yml

@@ -0,0 +1,32 @@
+name: "Copilot Setup Steps"
+
+# Automatically run the setup steps when they are changed to allow for easy validation, and
+# allow manual testing through the repository's "Actions" tab
+on:
+  workflow_dispatch:
+  pull_request:
+    paths:
+      - .github/workflows/copilot-setup-steps.yml
+
+jobs:
+    # The job MUST be called `copilot-setup-steps` or it will not be picked up by Copilot.
+  copilot-setup-steps:
+    runs-on: ubuntu-latest
+    permissions:
+      contents: read
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v5
+
+      - name: Set up JDK 21
+        uses: actions/setup-java@v5
+        with:
+          java-version: '21'
+          distribution: 'temurin'
+          cache: 'maven'
+
+      - name: Set up Maven 3.9.11
+        uses: stCarolas/setup-maven@v5
+        with:
+          maven-version: '3.9.11'
+

AGENTS.md

@@ -7,8 +7,8 @@ This file provides guidance to AI Agents (claude-code, codex, gemini cli, ...) w
 Eclipse Platform UI provides the UI building blocks for Eclipse IDE and Eclipse Rich Client Platform (RCP). This includes JFace, workbench, commands framework, data binding, dialogs, editors, views, perspectives, and more. Built on top of SWT (Eclipse Standard Widget Toolkit).
 
 **Key Facts:**
-- **Language:** Java 17
-- **Build System:** Maven 3.9.x with Tycho (OSGi/Eclipse plugin build)
+- **Language:** Java 21
+- **Build System:** Maven 3.9.11 with Tycho (OSGi/Eclipse plugin build)
 - **Architecture:** OSGi bundles, E4 application model
 
 ## Project Structure
@@ -64,10 +64,6 @@ Each bundle contains:
 
 ### Critical Limitation
 
-**⚠️ IMPORTANT:** Standalone `mvn clean verify` at repository root **WILL FAIL** with "Non-resolvable parent POM" error. This repository requires a parent POM from `eclipse.platform.releng.aggregator`.
-
-### Building Individual Bundles
-
 Use the `-Pbuild-individual-bundles` profile:
 
 ```bash

bundles/org.eclipse.e4.ui.css.core/src/org/eclipse/e4/ui/css/core/impl/sac/CSSDocumentHandlerImpl.java

@@ -91,7 +91,6 @@ public void ignorableAtRule(String atRule) throws CSSException {
 		if (!getNodeStack().empty()) {
 			((CSSRuleListImpl) getNodeStack().peek()).add(ir);
 		} else {
-			// _getNodeStack().push(ir);
 			nodeRoot = ir;
 		}
 	}
@@ -100,10 +99,6 @@ public void ignorableAtRule(String atRule) throws CSSException {
 	public void namespaceDeclaration(String prefix, String uri)
 			throws CSSException {
 		//TODO replace with eclipse logging
-		//		if (logger.isDebugEnabled()) {
-		//			logger.debug("Declare namespace [prefix=" + prefix + ", uri=" + uri
-		//					+ "]");
-		//		}
 	}
 
 	@Override
@@ -116,7 +111,6 @@ public void importStyle(String uri, SACMediaList media,
 		if (!getNodeStack().empty()) {
 			((CSSRuleListImpl) getNodeStack().peek()).add(ir);
 		} else {
-			// _getNodeStack().push(ir);
 			nodeRoot = ir;
 		}
 	}
@@ -125,27 +119,12 @@ public void importStyle(String uri, SACMediaList media,
 	public void startMedia(SACMediaList media) throws CSSException {
 
 		ignore = true;
-		//		// Create the media rule and add it to the rule list
-		//		CSSMediaRuleImpl mr = new CSSMediaRuleImpl(parentStyleSheet, null,
-		//				new MediaListImpl(media));
-		//		if (!getNodeStack().empty()) {
-		//			((CSSRuleListImpl) getNodeStack().peek()).add(mr);
-		//		}
-		//
-		//		// Create the rule list
-		//		CSSRuleListImpl rules = new CSSRuleListImpl();
-		//		mr.setRuleList(rules);
-		//		getNodeStack().push(mr);
-		//		getNodeStack().push(rules);
 	}
 
 	@Override
 	public void endMedia(SACMediaList media) throws CSSException {
 
 		ignore = false;
-		//		// Pop the rule list and media rule nodes
-		//		getNodeStack().pop();
-		//		nodeRoot = getNodeStack().pop();
 	}
 
 	@Override
@@ -176,26 +155,11 @@ public void endPage(String name, String pseudo_page) throws CSSException {
 	@Override
 	public void startFontFace() throws CSSException {
 		ignore = true;
-		//		// Create the font face rule and add it to the rule list
-		//		CSSFontFaceRuleImpl fontFaceRule = new CSSFontFaceRuleImpl(
-		//				parentStyleSheet, null);
-		//		if (!getNodeStack().empty()) {
-		//			((CSSRuleListImpl) getNodeStack().peek()).add(fontFaceRule);
-		//		}
-		//
-		//		// Create the style declaration
-		//		CSSStyleDeclarationImpl decl = new CSSStyleDeclarationImpl(fontFaceRule);
-		//		fontFaceRule.setStyle(decl);
-		//		getNodeStack().push(fontFaceRule);
-		//		getNodeStack().push(decl);
 	}
 
 	@Override
 	public void endFontFace() throws CSSException {
 		ignore = false;
-		//		// Pop both the style declaration and the font face rule nodes
-		//		getNodeStack().pop();
-		//		nodeRoot = getNodeStack().pop();
 	}
 
 	@Override

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/MenuManagerShowProcessor.java

@@ -123,8 +123,8 @@ public void menuAboutToHide(IMenuManager manager) {
 	 * {@link MDynamicMenuContribution} application model elements
 	 */
 	private void processDynamicElements(MMenu menuModel, MenuManager menuManager) {
-		MMenuElement[] menuElements = menuModel.getChildren().toArray(
-				new MMenuElement[menuModel.getChildren().size()]);
+		List<MMenuElement> children = menuModel.getChildren();
+		MMenuElement[] menuElements = children.toArray(new MMenuElement[children.size()]);
 		for (MMenuElement currentMenuElement : menuElements) {
 
 			if (currentMenuElement instanceof MDynamicMenuContribution dmc) {
@@ -154,9 +154,9 @@ private void processDynamicElements(MMenu menuModel, MenuManager menuManager) {
 				if (mel.size() > 0) {
 
 					int position = 0;
-					while (position < menuModel.getChildren().size()) {
-						if (currentMenuElement == menuModel.getChildren().get(
-								position)) {
+					children = menuModel.getChildren();
+					while (position < children.size()) {
+						if (currentMenuElement == children.get(position)) {
 							position++;
 							break;
 						}

bundles/org.eclipse.e4.ui.workbench.renderers.swt/src/org/eclipse/e4/ui/workbench/renderers/swt/StackRenderer.java

@@ -313,7 +313,7 @@ private void initializeOnboardingInformationInEditorStack(CTabFolder editorStack
 
 			String[] commandAndText = commands[i].split("\\$\\$\\$"); //$NON-NLS-1$
 
-			WidgetFactory.label(SWT.NONE).text(commandAndText[0]).foreground(color)
+			WidgetFactory.label(SWT.NONE).text(commandAndText[0]).foreground(color).align(SWT.RIGHT)
 					.supplyLayoutData(labelGridDataFactory::create).create(onboardingComposite);
 			WidgetFactory.label(SWT.NONE).text(commandAndText[1]).foreground(color)
 					.supplyLayoutData(commandGridDataFactory::create).create(onboardingComposite);

bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/SelectionProcessor.java

@@ -294,33 +294,6 @@ TextEdit replace(IMultiTextSelection selection, String replacement) {
 					TextEdit replace= new ReplaceEdit(region.getOffset(), region.getLength(), string);
 					root.addChild(replace);
 				}
-	//			while (lastDelim != -1) {
-	//				// more stuff to insert
-	//				String string;
-	//				Match m= delimiterMatcher.indexOf(replacement, lastDelim);
-	//				if (m == null) {
-	//					string= replacement.substring(lastDelim);
-	//					lastDelim= -1;
-	//				} else {
-	//					string= replacement.substring(lastDelim, m.getOffset());
-	//					lastDelim= m.getOffset() + m.getText().length();
-	//				}
-	//				endLine++;
-	//				TextEdit edit;
-	//				if (endLine < fDocument.getNumberOfLines()) {
-	//					edit= createReplaceEdit(endLine, visualStartColumn, visualEndColumn, string, delete);
-	//				} else {
-	//					// insertion reaches beyond the last line
-	//					int insertLocation= root.getExclusiveEnd();
-	//					int spaces= visualStartColumn;
-	//					char[] array= new char[spaces];
-	//					Arrays.fill(array, ' ');
-	//					string= TextUtilities.getDefaultLineDelimiter(fDocument) + String.valueOf(array) + string;
-	//					edit= new InsertEdit(insertLocation, string);
-	//					insertLocation+= string.length();
-	//				}
-	//				root.addChild(edit);
-	//			}
 				return root;
 			}
 		}

bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/html/HTMLPrinter.java

@@ -129,7 +129,7 @@ public static String read(Reader rd) {
 	 * @param bgRGB Background-Color
 	 * @param styleSheet Stylesheet
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void insertPageProlog(StringBuffer buffer, int position, RGB fgRGB, RGB bgRGB, String styleSheet) {
 		runOp(buffer, (sb) -> CORE.insertPageProlog(sb, position, fromRGB(fgRGB), fromRGB(bgRGB), styleSheet));
 	}
@@ -164,7 +164,7 @@ public static void insertStyles(StringBuilder buffer, String[] styles) {
 	 *
 	 * @deprecated As of 3.13, replaced by {@link #insertStyles(StringBuilder, String[])}
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void insertStyles(StringBuffer buffer, String[] styles) {
 		runOp(buffer, (sb) -> CORE.insertStyles(sb, styles));
 	}
@@ -186,7 +186,7 @@ public static void insertPageProlog(StringBuilder buffer, int position) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void insertPageProlog(StringBuffer buffer, int position) {
 		runOp(buffer, (sb) -> CORE.insertPageProlog(sb, position));
 	}
@@ -199,7 +199,7 @@ public static void insertPageProlog(StringBuffer buffer, int position) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void insertPageProlog(StringBuffer buffer, int position, URL styleSheetURL) {
 		runOp(buffer, (sb) -> CORE.insertPageProlog(sb, position, styleSheetURL));
 	}
@@ -234,7 +234,7 @@ public static void insertPageProlog(StringBuilder buffer, int position, String s
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void insertPageProlog(StringBuffer buffer, int position, String styleSheet) {
 		runOp(buffer, (sb) -> CORE.insertPageProlog(sb, position, styleSheet));
 	}
@@ -254,7 +254,7 @@ public static void addPageProlog(StringBuilder buffer) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addPageProlog(StringBuffer buffer) {
 		runOp(buffer, CORE::addPageProlog);
 	}
@@ -269,7 +269,7 @@ public static void addPageEpilog(StringBuilder buffer) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addPageEpilog(StringBuffer buffer) {
 		runOp(buffer, CORE::addPageEpilog);
 	}
@@ -289,7 +289,7 @@ public static void startBulletList(StringBuilder buffer) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void startBulletList(StringBuffer buffer) {
 		runOp(buffer, CORE::startBulletList);
 	}
@@ -311,7 +311,7 @@ public static void endBulletList(StringBuilder buffer) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void endBulletList(StringBuffer buffer) {
 		runOp(buffer, CORE::endBulletList);
 	}
@@ -335,7 +335,7 @@ public static void addBullet(StringBuilder buffer, String bullet) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addBullet(StringBuffer buffer, String bullet) {
 		runOp(buffer, (sb) -> CORE.addBullet(sb, bullet));
 	}
@@ -361,7 +361,7 @@ public static void addSmallHeader(StringBuilder buffer, String header) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addSmallHeader(StringBuffer buffer, String header) {
 		runOp(buffer, (sb) -> CORE.addSmallHeader(sb, header));
 	}
@@ -383,17 +383,17 @@ public static void addParagraph(StringBuilder buffer, String paragraph) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addParagraph(StringBuffer buffer, String paragraph) {
 		runOp(buffer, (sb) -> CORE.addParagraph(sb, paragraph));
 	}
 
 	/**
 	 * Appends a string and keeps its whitespace and newlines.
 	 * <p>
-	 * <b>Warning:</b> This starts a new paragraph when rendered in a browser, but
-	 * it doesn't starts a new paragraph when rendered with a {@link HTML2TextReader}
-	 * (e.g. in a {@link DefaultInformationControl} that renders simple HTML).
+	 * <b>Warning:</b> This starts a new paragraph when rendered in a browser, but it doesn't starts
+	 * a new paragraph when rendered with a {@link HTML2TextReader} (e.g. in a
+	 * {@link DefaultInformationControl} that renders simple HTML).
 	 *
 	 * @param buffer the output StringBuilder
 	 * @param preFormatted the string that should be rendered with whitespace preserved
@@ -409,9 +409,9 @@ public static void addPreFormatted(StringBuilder buffer, String preFormatted) {
 	/**
 	 * Appends a string and keeps its whitespace and newlines.
 	 * <p>
-	 * <b>Warning:</b> This starts a new paragraph when rendered in a browser, but
-	 * it doesn't starts a new paragraph when rendered with a {@link HTML2TextReader}
-	 * (e.g. in a {@link DefaultInformationControl} that renders simple HTML).
+	 * <b>Warning:</b> This starts a new paragraph when rendered in a browser, but it doesn't starts
+	 * a new paragraph when rendered with a {@link HTML2TextReader} (e.g. in a
+	 * {@link DefaultInformationControl} that renders simple HTML).
 	 *
 	 * @param buffer the output buffer
 	 * @param preFormatted the string that should be rendered with whitespace preserved
@@ -422,7 +422,7 @@ public static void addPreFormatted(StringBuilder buffer, String preFormatted) {
 	 * @see #convertToHTMLContentWithWhitespace(String)
 	 * @since 3.7
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addPreFormatted(StringBuffer buffer, String preFormatted) {
 		runOp(buffer, (sb) -> CORE.addPreFormatted(sb, preFormatted));
 	}
@@ -444,7 +444,7 @@ public static void addParagraph(StringBuilder buffer, Reader paragraphReader) {
 	 *
 	 * @deprecated migrate to new StringBuilder API
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public static void addParagraph(StringBuffer buffer, Reader paragraphReader) {
 		runOp(buffer, (sb) -> CORE.addParagraph(sb, paragraphReader));
 	}

bundles/org.eclipse.jface.text/src/org/eclipse/jface/internal/text/revisions/RevisionPainter.java

@@ -382,16 +382,16 @@ protected IInformationControl doCreateInformationControl(Shell parent) {
 					 *
 					 * @deprecated use {@link #setInput(Object)}
 					 */
-					@Deprecated
+					@Deprecated(forRemoval= true, since= "2025-12")
 					@Override
 					public void setInformation(String content) {
 						content= addCSSToHTMLFragment(content);
 						super.setInformation(content);
 					}
 
 					/**
-					 * Adds a HTML header and CSS info if <code>html</code> is only an HTML fragment (has no
-					 * &lt;html&gt; section).
+					 * Adds a HTML header and CSS info if <code>html</code> is only an HTML fragment
+					 * (has no &lt;html&gt; section).
 					 *
 					 * @param html the html / text produced by a revision
 					 * @return modified html

bundles/org.eclipse.jface.text/src/org/eclipse/jface/text/DefaultInformationControl.java

@@ -232,7 +232,7 @@ public DefaultInformationControl(Shell parent, IInformationPresenter presenter)
 	 * @param presenter the presenter to be used
 	 * @deprecated As of 3.4, replaced by simpler constructors
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public DefaultInformationControl(Shell parent, int shellStyle, int style, IInformationPresenter presenter) {
 		this(parent, shellStyle, style, presenter, null);
 	}
@@ -269,7 +269,7 @@ public DefaultInformationControl(Shell parentShell, int shellStyle, final int st
 	 * @param presenter the presenter to be used
 	 * @deprecated As of 3.4, replaced by {@link #DefaultInformationControl(Shell, DefaultInformationControl.IInformationPresenter)}
 	 */
-	@Deprecated
+	@Deprecated(forRemoval= true, since= "2025-12")
 	public DefaultInformationControl(Shell parent, int textStyles, IInformationPresenter presenter) {
 		this(parent, textStyles, presenter, null);
 	}