-
Notifications
You must be signed in to change notification settings - Fork 2.5k
gst-plugins-bad1: enable build with nvcodec #54128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
classabbyamp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revision needs to be incremented
cea9f48 to
e55c3f1
Compare
|
Thanks! I have bumped the revision and fixed a trailing whitespace |
|
fyi, update here #53936 |
Then I assume the correct way to merge this would be to wait till 1.24.11 gets merged and then rebase my branch? |
|
just a heads up. similar thing happened with blender a bit back and theyre in limbo |
|
it's not in "limbo", both PRs had unaddressed feedback |
|
@classabbyamp I see this got merged, thanks! :) However something seems to have gone wrong. When I install the package from the official repository the plugin is still not available. The logs in this pull request shows that it is built and stripped but for some reason it is not in the repo yet even though the package I install is with the version and revision from this pull request. If you check the build logs for x86_64 in this pull request on line 2686 it says:
indicating that it did in fact get built as expected. If we do |
|
Perfect! It's there now :) |

This change adds the nv-codec-headers package as a build dependency to gst-plugins-bad1 enabling the build of the nvcodec plugins.
Testing the changes
Local build testing