Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions srcpkgs/magic-wormhole/template
Original file line number Diff line number Diff line change
@@ -1,19 +1,21 @@
# Template file for 'magic-wormhole'
pkgname=magic-wormhole
version=0.15.0
revision=3
version=0.22.0
revision=1
build_style=python3-pep517
hostmakedepends="python3 python3-build python3-setuptools python3-wheel"
hostmakedepends="python3 python3-build python3-setuptools python3-wheel
python3-versioneer"
depends="python3-autobahn python3-cffi python3-click python3-humanize
python3-idna python3-pynacl python3-service_identity python3-spake2
python3-tqdm python3-txtorcon python3-iterable-io python3-zipstream-ng"
python3-idna python3-pynacl python3-service_identity python3-spake2 python3-tqdm
python3-txtorcon python3-iterable-io python3-zipstream-ng python3-qrcode
python3-Twisted python3-attrs python3-automat python3-cryptography"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
python3-Twisted python3-attrs python3-automat python3-cryptography"
python3-Twisted python3-attrs python3-automat python3-cryptography"
checkdepends="python3-pytest-xdist ${depends}"

Add checkdepends if this package will run tests. Sometimes, parallel tests will fail, so you can replace python3-pytest-xdist with python3-pytest if needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic-wormhole already runs tests in their CI for each release but we can run them again to make sure that there's no issues with the dependency versions in Void maybe?

So you're saying to just add pytest as a checkdepend to take advantage of do_check() in the python3-pep517 build style?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default do_check() from the build style doesn't run because the tests require pytest-twisted which we don't have, but magic-wormhole's CI workflow uses tox -e coverage so we could just do that in a do_check?

Suggested change
python3-Twisted python3-attrs python3-automat python3-cryptography"
python3-Twisted python3-attrs python3-automat python3-cryptography"
checkdepends="tox ${depends}"

And then a

do_check() {
	tox -e coverage
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. If we don't have the necessary dependencies, disregard my request. Running tox will set up a virtual environment and won't test the package that we actually build and distribute.

short_desc="Get things from one computer to another, safely"
maintainer="travankor <[email protected]>"
license="MIT"
homepage="https://magic-wormhole.readthedocs.io/en/latest/"
changelog="https://raw.githubusercontent.com/magic-wormhole/magic-wormhole/master/NEWS.md"
distfiles="https://github.com/warner/magic-wormhole/archive/${version}.tar.gz"
checksum=bc77b7280876ad0e9611498cdee1aebb3d0ec0a9236bf7356dc8967f2d6ce201
distfiles="https://github.com/magic-wormhole/magic-wormhole/archive/${version}.tar.gz"
checksum=14a6029263c49109d71b0d0a82737690645d33f4067513bce2c7cca20da837ab

post_install() {
vlicense LICENSE
Expand Down