Skip to content

Conversation

@gc-user
Copy link
Contributor

@gc-user gc-user commented Nov 12, 2025

Testing the changes

  • I tested the changes in this PR: briefly

Local build testing

  • I built this PR locally for my native architecture, (x86_64)

@ahesford
Copy link
Member

Please resolve conflicts.

@gc-user gc-user marked this pull request as draft December 31, 2025 10:01
@gc-user gc-user marked this pull request as ready for review December 31, 2025 10:01
@gc-user gc-user marked this pull request as draft December 31, 2025 10:14
@gc-user
Copy link
Contributor Author

gc-user commented Dec 31, 2025

Yeah, I messed up. I just don't like the Github WebUI software's logic...
As git filter-branch apparently is a giant no-no for public repos, I guess I have to close this PR (delete my branch) and create a new one...

@ahesford
Copy link
Member

Just squash these commits down and force-push back to the branch. There is no need to close anything. Don't use the GitHub web UI for contributions. It is unsuitable for anything beyond a trivial change.

@gc-user
Copy link
Contributor Author

gc-user commented Dec 31, 2025

Well, I didn't know how to solve the confict on terminal, and the webui used the no-reply email.
Now that the brach "master" was merged into my branch using the no-reply email I can't go back to before the merge...

@gc-user
Copy link
Contributor Author

gc-user commented Dec 31, 2025

Ok, maybe reset hard works. I'll try that before giving up.

@gc-user
Copy link
Contributor Author

gc-user commented Dec 31, 2025

Yeah, even with the correct email address lint fails. Maybe there were some changes made recently to the CONTRIBUTING.md guildelines that don't accept the PR / commits I made way back when anymore.
I make a new branch which is then also up-to-date and retry an see if it still fails. If it does, I'll just make two PRs.

@gc-user
Copy link
Contributor Author

gc-user commented Dec 31, 2025

Yeah, I don't know what's the issue.
Anyway, the new PR seems to be fine, so I'll close this one and go with the new one.

@gc-user gc-user closed this Dec 31, 2025
@gc-user gc-user deleted the nvme branch December 31, 2025 18:06
@ahesford
Copy link
Member

Please familiarize yourself with git history manipulations and avoid doing this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants