Skip to content

Display bundle size numbers with commas in absolute bytes #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Boshen merged 2 commits into from
Aug 25, 2025
Merged

Display bundle size numbers with commas in absolute bytes #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42689f4
Initial plan
Copilot Aug 25, 2025
71eb819
Implement bundle size formatting with commas and absolute numbers
Copilot Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions apps/dashboard/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,11 @@ import { BarChart3, Clock, Package, FileText } from 'lucide-react'
import './App.css'
import rolldownStats from '../../../rolldown-version-stats.json'

// Utility function to format numbers with commas
const formatNumberWithCommas = (num: number): string => {
return num.toLocaleString()
}

// Transform rolldown stats data for charts
const buildTimeData = rolldownStats.map(stat => ({
name: `v${stat.version}`,
Expand All @@ -12,7 +17,7 @@ const buildTimeData = rolldownStats.map(stat => ({

const bundleSizeData = rolldownStats.map(stat => ({
name: `v${stat.version}`,
value: Math.round(stat.totalSize / 1024) // Convert to KB
value: stat.totalSize // Use actual bytes instead of KB
}))

// Calculate file type breakdown from all versions
Expand All @@ -37,6 +42,14 @@ const fileTypeData = Object.entries(fileTypeStats).map(([type, size]) => ({
function App() {
const [selectedMetric, setSelectedMetric] = useState('buildTime')

// Custom tooltip formatter for bundle size
const customTooltipFormatter = (value: any, name: string) => {
if (selectedMetric === 'bundleSize') {
return [formatNumberWithCommas(value), name]
}
return [value, name]
}

const metrics = [
{ id: 'buildTime', name: 'Build Time', icon: Clock, data: buildTimeData, color: '#8884d8' },
{ id: 'bundleSize', name: 'Bundle Size', icon: Package, data: bundleSizeData, color: '#82ca9d' },
Expand Down Expand Up @@ -94,12 +107,12 @@ function App() {
<CartesianGrid strokeDasharray="3 3" />
<XAxis dataKey="name" />
<YAxis />
<Tooltip />
<Tooltip formatter={selectedMetric === 'bundleSize' ? customTooltipFormatter : undefined} />
<Legend />
<Bar
dataKey="value"
fill={currentMetric.color}
name={selectedMetric === 'buildTime' ? 'Build Time (ms)' : 'Bundle Size (KB)'}
name={selectedMetric === 'buildTime' ? 'Build Time (ms)' : 'Bundle Size (bytes)'}
/>
</BarChart>
)}
Expand All @@ -114,7 +127,7 @@ function App() {
</div>
<div className="stat-card">
<h3>Latest Bundle Size</h3>
<p className="stat-value">{bundleSizeData[bundleSizeData.length - 1]?.value}KB</p>
<p className="stat-value">{formatNumberWithCommas(bundleSizeData[bundleSizeData.length - 1]?.value || 0)} bytes</p>
<span className="stat-change positive">v{rolldownStats[rolldownStats.length - 1]?.version}</span>
</div>
<div className="stat-card">
Expand Down