Fix Recharts v3 compatibility issues for LabelList formatter API #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the TypeScript compilation errors introduced by the Recharts v3 upgrade in PR #52. The breaking change affected the
LabelListcomponent'sformatterprop signature.Problem
Recharts v3 changed the
LabelListformatter API:formatter?: (value: number) => stringformatter?: (label: ReactNode) => ReactNodeThis caused 4 TypeScript errors across the dashboard:
Solution
Updated all
LabelListformatter functions to use the new v3 API:MinificationBenchmarks.tsx (2 instances):
formatter={(label: React.ReactNode) => \${label}ms`}`formatter={(label: React.ReactNode) => \${label}%`}`RolldownStats.tsx (2 instances):
formatter={(label: React.ReactNode) => \${label}ms`}`The changes maintain full backward compatibility while ensuring type safety with the new Recharts v3 API.
Verification
Fixes #56.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.