Skip to content

Fix: Proper redirect URL when we have just one Notebook#76

Draft
martinRenou wants to merge 1 commit intovoila-dashboards:mainfrom
martinRenou:count_notebooks
Draft

Fix: Proper redirect URL when we have just one Notebook#76
martinRenou wants to merge 1 commit intovoila-dashboards:mainfrom
martinRenou:count_notebooks

Conversation

@martinRenou
Copy link
Member

References

I've encountered this in https://github.com/martinRenou/voici-jupytercon-2023 where our content is a directory with just one Notebook with a data file. Then the redirect URL would not automatically be the Notebook.

Code changes

Actually count the Notebooks in the contents

@martinRenou martinRenou requested a review from trungleduc May 3, 2023 14:18
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

lite-badge 👈 Try it on ReadTheDocs

@trungleduc
Copy link
Member

Do we want this behavior? Because it's not the same as in voila.

@trungleduc
Copy link
Member

Thinking of it, there is no way to start a single dashboard with external files without using the directory as contents, should we split the path to notebooks and the path to the resources dir in the CLI?

@martinRenou martinRenou marked this pull request as draft May 3, 2023 14:24
@martinRenou
Copy link
Member Author

Thinking of it, there is no way to start a single dashboard with external files without using the directory as contents

Exactly, that was the original intent of the PR. I haven't thought of the impact on the CLI api that diverges from Voila.

should we split the path to notebooks and the path to the resources dir in the CLI?

I don't know.

Maybe this needs further discussion and we should not rush into implementing something before JupyterCon. I turn this into draft and we can discuss further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants