Skip to content

chore: allow PHPUnit 11 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chris53897 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore: allow PHPUnit 11 #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"voku/portable-utf8": "~6.0.2"
},
"require-dev": {
"phpunit/phpunit": "~6.0 || ~7.0 || ~9.0"
"phpunit/phpunit": "~6.0 || ~7.0 || ~9.0 || ~10.0 || ~11.0"
},
"autoload": {
"psr-4": {
Expand Down
4 changes: 3 additions & 1 deletion tests/LaravelSecurityTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
* file that was distributed with this source code.
*/

use PHPUnit\Framework\Attributes\DataProvider;
use voku\helper\AntiXSS;

/**
Expand All @@ -25,7 +26,7 @@ final class LaravelSecurityTest extends \PHPUnit\Framework\TestCase
/**
* @return array
*/
public function snippetProvider()
public static function snippetProvider()
{
return [
[
Expand Down Expand Up @@ -234,6 +235,7 @@ public function snippetProvider()
* @param $input
* @param $output
*/
#[DataProvider('snippetProvider')]
public function testCleanString($input, $output)
{
$security = $this->getSecurity();
Expand Down
7 changes: 5 additions & 2 deletions tests/XssTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

declare(strict_types=1);

use PHPUnit\Framework\Attributes\DataProvider;
use voku\helper\AntiXSS;
use voku\helper\UTF8;

Expand Down Expand Up @@ -1641,6 +1642,7 @@ public function testXssCleanSanitizeNaughtyHtml()
/**
* @dataProvider _dataForXssCleanSanitizeNaughtyJavascript
*/
#[DataProvider('_dataForXssCleanSanitizeNaughtyJavascript')]
public function testXssCleanSanitizeNaughtyJavascript(string $contentToFilter, bool $expectedFindXss)
{
// Arrange
Expand All @@ -1659,7 +1661,7 @@ public function testXssCleanSanitizeNaughtyJavascript(string $contentToFilter, b
}
}

public function _dataForXssCleanSanitizeNaughtyJavascript(): array
public static function _dataForXssCleanSanitizeNaughtyJavascript(): array
{
return [
// no XSS
Expand All @@ -1682,6 +1684,7 @@ public function _dataForXssCleanSanitizeNaughtyJavascript(): array
/**
* @dataProvider _dataForXssXssCleanNeverAllowedAfterwards
*/
#[DataProvider('_dataForXssXssCleanNeverAllowedAfterwards')]
public function testXssCleanNeverAllowedAfterwards(string $contentToFilter, bool $expectedFindXss)
{
// Arrange
Expand All @@ -1700,7 +1703,7 @@ public function testXssCleanNeverAllowedAfterwards(string $contentToFilter, bool
}
}

public function _dataForXssXssCleanNeverAllowedAfterwards(): array
public static function _dataForXssXssCleanNeverAllowedAfterwards(): array
{
return [
'valid string without attribute XSS #5' => ['<p>onend</p>', false],
Expand Down