Do not yield DRIVER_OBJECT instances found in scanning that are not a…#1488
Do not yield DRIVER_OBJECT instances found in scanning that are not a…#1488
Conversation
ikelos
left a comment
ikelos
left a comment
There was a problem hiding this comment.
Never seen a variable just accessed without an assignment or anything, but if it works? Just want to check that getting back a structure with only one of those is still worthwhile...
| # of interest to plugins, so if it is not accessible then this instance | ||
| # is not useful or usable during analysis | ||
| try: | ||
| mem_object.DriverStart |
There was a problem hiding this comment.
Is just listing a variable enough to trip the output? I'd think that could get optimized out? Also, don't we care if the whole structure is valid, or would having just DriverStart be enough?
atcuno
force-pushed
the
issue_1481_driver_objects
branch
from
49dbb01 to
8df8f77
Compare
|
@ikelos this is ready but not sure if a version bump is needed due to the error paths in |
|
Looks like some tests need updating here? I dunno whether we lost legit values or something else went wrong, but it needs someone to look into it. Technically it should get a bump given the return type is changed. If it's not too hard to put it, it would probably be worthwhile, just in case it does affect someone... |
ikelos
added
the
awaiting-author-response
|
Why did this get closed? The associated ticket was also closed, did the problem just go away or did it get solved a different way? |
|
This issue plus several others that popped up in testing are covered here: #1621 |
2 participants
…ctual instances #1481