Linux - Harden mountinfo API and several related fixes#1545
Merged
ikelos merged 12 commits intovolatilityfoundation:developfrom Jan 30, 2025
Conversation
…eprocessor macro shortcuts, not actual members of the type.
…th the 'dentry' class.
…rray and a count value, it will end up with an AttributeError exception
ikelos
reviewed
Jan 16, 2025
Member
ikelos
left a comment
There was a problem hiding this comment.
Generally happy with all of this, although not sure why the function signature for one bit changed (and without that change, there's no need for version bumps that I can see). Needs a response to some of the points raised but no showstoppers at least...
Contributor
Author
|
@ikelos thanks for the review. All the observations were addressed |
Contributor
Author
|
@ikelos hold on with this as it seems there's a commit missing |
Contributor
Author
|
@ikelos no worries, it's all good! Turns out it was just how GitHub was displaying the changes, pretty confusing at first |
ikelos
approved these changes
Jan 30, 2025
Member
ikelos
left a comment
There was a problem hiding this comment.
Ok, looks good, let's go for it. 5:)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the context of #1516 and related issues, this PR addresses several issues in the mountinfo API code and its associated functions.
This PR includes:
f_dentryandf_vfsmntmembers were incorrectly included, though they were never part of struct file. These were preprocessor macros used as shortcuts within kernel code but should not be present in the structure itself.